-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade pip to v23.0.1 #384
Conversation
Thanks @danielhollas! I have a vague memory that there is some reason the pip version needs to be pinned under |
Good call, thanks! It looks like the pip version was constrained here #271, but the the underlying issue was a deprecation of a pip cmdline option that we've been using in |
@unkcpz I've tested installation of all apps that are currently available in the new docker stack and things seem to work. |
Thanks @danielhollas. I rebase the arm64 support PR, for safety let's get that merge first and have this PR test for the arm64 (I think it will be all fine, the packages from pip always noarch specific). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good! thanks @danielhollas
We constrain the pip version via the requirements.txt file. The current pip version is more than a year old, so I think it is time for an upgrade. More specifically, my motivation was pragmatic: since version v23.0.0,
pip show
command will print when the package was installed in an editable mode. This is super useful for developers, because I am often bitten by the fact that I forgot to install my package in an editable mode and my changes were not picked up. Now I can quickly runpip show
to check that.v23.0.0 version has been released in 30th January this year, so should be safe to use. I've purposefully did not upgrade all the way to 23.1. I went through the pip changelog and did not see any obvious breaking changes that would affect us. But we need to test.