Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pip to v23.0.1 #384

Merged
merged 5 commits into from
May 26, 2023
Merged

Upgrade pip to v23.0.1 #384

merged 5 commits into from
May 26, 2023

Conversation

danielhollas
Copy link
Contributor

@danielhollas danielhollas commented May 23, 2023

We constrain the pip version via the requirements.txt file. The current pip version is more than a year old, so I think it is time for an upgrade. More specifically, my motivation was pragmatic: since version v23.0.0, pip show command will print when the package was installed in an editable mode. This is super useful for developers, because I am often bitten by the fact that I forgot to install my package in an editable mode and my changes were not picked up. Now I can quickly run pip show to check that.

v23.0.0 version has been released in 30th January this year, so should be safe to use. I've purposefully did not upgrade all the way to 23.1. I went through the pip changelog and did not see any obvious breaking changes that would affect us. But we need to test.

@unkcpz
Copy link
Member

unkcpz commented May 23, 2023

Thanks @danielhollas! I have a vague memory that there is some reason the pip version needs to be pinned under <22.3, related to some setuptool issue. I'll have a search. If everything is just fine, sure, we need to use the latest version.

@danielhollas
Copy link
Contributor Author

Good call, thanks! It looks like the pip version was constrained here #271, but the the underlying issue was a deprecation of a pip cmdline option that we've been using in aiidalab package. But was fixed a long time since aiidalab/aiidalab#297 so I think we should be good here. But I will test this thoroughly.

@danielhollas danielhollas marked this pull request as ready for review May 24, 2023 21:26
@danielhollas danielhollas requested a review from unkcpz May 24, 2023 21:26
@danielhollas
Copy link
Contributor Author

@unkcpz I've tested installation of all apps that are currently available in the new docker stack and things seem to work.

@unkcpz
Copy link
Member

unkcpz commented May 24, 2023

Thanks @danielhollas. I rebase the arm64 support PR, for safety let's get that merge first and have this PR test for the arm64 (I think it will be all fine, the packages from pip always noarch specific).

@danielhollas danielhollas added the blocked This issue/PR is blocked by another issue/PR. label May 24, 2023
@unkcpz unkcpz added this to the 2023.1012 milestone May 25, 2023
@unkcpz unkcpz mentioned this pull request May 26, 2023
3 tasks
@unkcpz unkcpz removed the blocked This issue/PR is blocked by another issue/PR. label May 26, 2023
Copy link
Member

@unkcpz unkcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! thanks @danielhollas

@unkcpz unkcpz merged commit 6538622 into main May 26, 2023
7 checks passed
@unkcpz unkcpz deleted the upgrade-pip branch May 26, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants