Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Python 3.11 image 👀 #389

Closed
wants to merge 7 commits into from
Closed

Test Python 3.11 image 👀 #389

wants to merge 7 commits into from

Conversation

danielhollas
Copy link
Contributor

@danielhollas danielhollas commented Jun 27, 2023

No description provided.

I don't understand why this is suddenly necessary.
@danielhollas danielhollas changed the title Test Python 3.11 image 🎉 Test Python 3.11 image 👀 Jun 27, 2023
@danielhollas
Copy link
Contributor Author

The image builds, but AWB cannot be installed, since optimade==0.18 is not available for Python 3.11.
This dependency needs to be unpinned / upgraded in the optimade-client package (to at least version optimade==0.21.0.

https://github.com/CasperWA/voila-optimade-client/blob/5f4ffbbe66aed1406e09601ad8af7fe241d6bd2a/requirements/requirements_base.txt#L6

@danielhollas
Copy link
Contributor Author

I've opened an issue on the optimade-client package.

CasperWA/voila-optimade-client#506

@unkcpz unkcpz force-pushed the main branch 4 times, most recently from 486feb1 to 0897d53 Compare July 10, 2023 23:18
@danielhollas
Copy link
Contributor Author

Just did a quick test, and it looks like upgrade to Python 3.11 would speed up loading of my application by ~600ms. 🎉

So definitely worth to pursue this, but obviously we first need to update to 3.10.

@danielhollas
Copy link
Contributor Author

Closing for now, need to upgrade to 3.10 first.

@danielhollas danielhollas deleted the python3.11 branch May 13, 2024 23:55
@danielhollas
Copy link
Contributor Author

Just a note for my future self, the version docker.io/jupyter/minimal-notebook:python-3.11.3 is the last version that ships with notebook==6.5 so that's what we should target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant