Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove QE build #438

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Remove QE build #438

merged 1 commit into from
Mar 20, 2024

Conversation

danielhollas
Copy link
Contributor

I believe the image with QeApp is now build in aiidalab-qe repo, so removing some of its vestiges here.

CC @unkcpz correct me if I am wrong.

unkcpz
unkcpz approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@unkcpz unkcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's true, I am surprise (and awkward 😅 ) I forget to remove those

@danielhollas
Copy link
Contributor Author

Cool, thanks. Going to merge this, adm64 build succeeded and there's nothing here that should make arm64 fail.

@danielhollas danielhollas merged commit df4bb5a into main Mar 20, 2024
16 of 25 checks passed
@danielhollas danielhollas deleted the remove-qe-build branch March 20, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unkcpz unkcpz unkcpz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danielhollas @unkcpz