Speedup container startup #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@unkcpz can you test if this image from this PR starts faster? (I would expect at least 5s faster, not solving your problem, but still nice) |
|
Thanks @danielhollas, I also notice the slow down of the unnecessary migration I think this is the one bring most improvement. Will give this a look! |
|
On my machine, I ran and it took ~13s, while the latest image takes ~18s. |
unkcpz
requested changes
May 17, 2024
There was a problem hiding this comment.
Hi @danielhollas, let me know when this is ready for review.
danielhollas
commented
May 17, 2024
danielhollas
commented
May 17, 2024
danielhollas
commented
May 17, 2024
danielhollas
commented
May 17, 2024
|
@unkcpz ready for review. I got rid of one more verdi invocation. |
danielhollas
changed the title
danielhollas
force-pushed
the
speedup-startup
branch
2 times, most recently
from
06210df
to
6f639aa
Compare
|
@superstar54 this one is ready to go. Would be great if you could have a look when you have a bit of time. Thanks! |
This was referenced May 23, 2024
unkcpz
reviewed
Jun 4, 2024
unkcpz
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main strategy here is to remove all unneeded verdi invocations, because each one costs at least 0.5s.