Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom parameters to start-notebook.sh #155

Open
danielhollas opened this issue Oct 3, 2022 · 0 comments
Open

Support custom parameters to start-notebook.sh #155

danielhollas opened this issue Oct 3, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@danielhollas
Copy link
Contributor

Motivation

In the jupyter-docker-stacks Docs, the proposed solution for HTTPS connection to the notebook is to mount the certificates via volume (this we can already do via custom mounts config 🎉) and passing extra config parameters to the start-notebook.sh commands.

docker run -it --rm -p 8888:8888 \
    -v /some/host/folder:/etc/ssl/notebook \
    jupyter/base-notebook \
    start-notebook.sh \
    --NotebookApp.keyfile=/etc/ssl/notebook/notebook.key \
    --NotebookApp.certfile=/etc/ssl/notebook/notebook.crt

There are other Jupyter config options that might be useful in this way, e.g. setting up a password

https://jupyter-docker-stacks.readthedocs.io/en/latest/using/common.html#jupyter-server-options

Proposal

Add a new configuration option, perhaps titles JUPYTER_SERVER_OPTIONS, by default empty, and pass it on when starting a container.

If this all sound okay to you @csadorf I can take this on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant