Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile settings. #98

Open
yakutovicha opened this issue Feb 16, 2022 · 2 comments
Open

Profile settings. #98

yakutovicha opened this issue Feb 16, 2022 · 2 comments
Labels
question Further information is requested

Comments

@yakutovicha
Copy link
Member

Just a few other thoughts I had while working with the tool:

  • I think it doesn't make sense to fix the port number in the profile config. If one has something else running on port 8888 (typically Jupyter notebook), things get confusing. Maybe we should perform an automatic port check the same that the Jupyter notebook does?
  • Wouldn't it make more sense to keep the container name in the config? Users might want to change it.
@yakutovicha yakutovicha added the question Further information is requested label Feb 16, 2022
@csadorf
Copy link
Member

csadorf commented Feb 17, 2022

  • I think it doesn't make sense to fix the port number in the profile config. If one has something else running on port 8888 (typically Jupyter notebook), things get confusing. Maybe we should perform an automatic port check the same that the Jupyter notebook does?

The port is currently fixed for the default configuration, however setting it to an empty value (port = "") will have docker choose a port automatically. If I understand correctly, that would be your preferred mode? It would mean that the port would change on every start/restart.

  • Wouldn't it make more sense to keep the container name in the config? Users might want to change it.

The container name is determined from the profile name and a hard-coded prefix. This is how the tool is able to automatically identify the associated container and volumes (similar to how docker-compose does this).

It seems to me that adding the ability to change the container name would introduce a lot of complexity (e.g. one would have to prevent users from doing so while the container is running) without much benefit. Why exactly would a user want to change the container name?

@danielhollas
Copy link
Contributor

@yakutovicha are you okay to close this issue?

Based on my experience I think the current status quo is okay. Having a variable port on each startup would be very confusing, and would break browser URL bar autocompletion that I am relying on when connecting remotely to Aiidalab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants