Fix mount configuration change check for bind mounts #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docker_mount_for() returns Path for bind mounts, which resulted in a type mismatch even when configuration did not change, and users would get spurious warnings.
danielhollas
commented
Jun 21, 2022
Merged
Codecov Report
@@ Coverage Diff @@
## main #134 +/- ##
=======================================
Coverage 86.19% 86.19%
=======================================
Files 9 9
Lines 826 826
=======================================
Hits 712 712
Misses 114 114
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
The CI fail is just Codecov failing to upload, re-running will hopefully fix it. |
|
@danielhollas I suggest that we wait with a release until after #132 is merged, but please let me know if you would prefer for me to make a release right away. |
|
Yes, let's wait for #132, thanks!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker_mount_for() returns Path for bind mounts, which resulted in a type mismatch even when configuration did not change, and users would get spurious warnings.
I modified two tests so that they would catch the bug.
CC @csadorf this is the bug I mentioned in #132.