Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support aiidalab/full-stack #149

Merged
merged 10 commits into from
Sep 29, 2022
Merged

Support aiidalab/full-stack #149

merged 10 commits into from
Sep 29, 2022

Conversation

csadorf
Copy link
Member

@csadorf csadorf commented Aug 31, 2022

  • Implement migration path
  • Implement tests

@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Base: 86.14% // Head: 86.33% // Increases project coverage by +0.18% 🎉

Coverage data is based on head (8fbbfd8) compared to base (0ce3d34).
Patch coverage: 77.77% of modified lines in pull request are covered.

❗ Current head 8fbbfd8 differs from pull request most recent head 178cba6. Consider uploading reports for the commit 178cba6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
+ Coverage   86.14%   86.33%   +0.18%     
==========================================
  Files           9        9              
  Lines         895      900       +5     
==========================================
+ Hits          771      777       +6     
+ Misses        124      123       -1     
Flag Coverage Δ
py-3.10 86.22% <77.77%> (+0.18%) ⬆️
py-3.8 86.17% <77.77%> (+0.18%) ⬆️
py-3.9 86.28% <77.77%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiidalab_launch/instance.py 87.13% <50.00%> (-0.28%) ⬇️
aiidalab_launch/profile.py 96.84% <100.00%> (+0.10%) ⬆️
aiidalab_launch/util.py 85.24% <0.00%> (+1.63%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@csadorf csadorf self-assigned this Sep 6, 2022
README.md Outdated Show resolved Hide resolved
@csadorf csadorf force-pushed the support-full-stack-lab branch 4 times, most recently from 25934b0 to 11155c7 Compare September 15, 2022 17:08
@csadorf csadorf changed the title Support full stack lab Support aiidalab/full-stack Sep 15, 2022
@csadorf
Copy link
Member Author

csadorf commented Sep 28, 2022

This PR appears ready to me, however some of the tests seemingly randomly time out. I'd like to at least try to figure out what the root cause might be before introducing this kind of flakiness into the main branch.

@csadorf csadorf marked this pull request as ready for review September 28, 2022 15:19
@csadorf csadorf requested a review from unkcpz September 28, 2022 15:56
Copy link
Member

@unkcpz unkcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@csadorf Thanks a lot for working on this! I think all great, but I didn't run it to test. But I think we can get it merged and I will do the actual run on my computer.
Only some minor questions may be better to clarified before merging.

aiidalab_launch/instance.py Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
aiidalab_launch/profile.py Outdated Show resolved Hide resolved
@csadorf csadorf enabled auto-merge (squash) September 29, 2022 12:41
@csadorf csadorf merged commit 49e66d1 into main Sep 29, 2022
@csadorf csadorf deleted the support-full-stack-lab branch September 29, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants