-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support aiidalab/full-stack #149
Conversation
Codecov ReportBase: 86.14% // Head: 86.33% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #149 +/- ##
==========================================
+ Coverage 86.14% 86.33% +0.18%
==========================================
Files 9 9
Lines 895 900 +5
==========================================
+ Hits 771 777 +6
+ Misses 124 123 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
25934b0
to
11155c7
Compare
Script is not provided on the full-stack image.
Selecting a different user is currently creating problems, see aiidalab/aiidalab-docker-stack#297 .
Allow test parametrization w.r.t. the default image.
11155c7
to
1cd276e
Compare
This PR appears ready to me, however some of the tests seemingly randomly time out. I'd like to at least try to figure out what the root cause might be before introducing this kind of flakiness into the main branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@csadorf Thanks a lot for working on this! I think all great, but I didn't run it to test. But I think we can get it merged and I will do the actual run on my computer.
Only some minor questions may be better to clarified before merging.
Implement migration path