Call echo_logs only when in DEBUG mode #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 86.72% // Head: 86.54% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #167 +/- ##
==========================================
- Coverage 86.72% 86.54% -0.18%
==========================================
Files 9 9
Lines 904 907 +3
==========================================
+ Hits 784 785 +1
- Misses 120 122 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
danielhollas
force-pushed
the
flaky-tests-again
branch
from
519c085
to
9dd8a9f
Compare
This reverts commit ff15465.
danielhollas
changed the title
unkcpz
approved these changes
Feb 23, 2023
|
I am going to release it after this one is merged. |
|
@unkcpz thanks. Feel free to merge, I do not have permissions. |
|
@danielhollas merged thanks!
Let me know if you need higher permission for convenient management. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
echo_logsfunction prints out the logs from the container (i.e. the output ofaiidalab-launch logs) while the user waits for the container to start. However, logs are printed withlogging.DEBUGso there's no point in calling this function unless this level of logging is enabled (via the-vvvcmdline parameter).We have some indication that this function is problematic in #154 so calling it only when neccessary might help. We also have issues with flaky tests, #163. While the change here does not solve the flakiness (see failures here and here), it does seem to help since the test suite no longer times out, but actually fails in a reasonable amount of time. I haven't been able to pinpoint the reason for the failures, looking at the error messages it seems that the container fails to start randomly. So more investigation is needed but this seems to be a step in right direction at least.