Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate py3.8 and deal with action warnings #183

Closed
wants to merge 1 commit into from

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented May 29, 2023

No description provided.

@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.22 🎉

Comparison is base (d3c121f) 86.54% compared to head (466cba0) 86.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #183      +/-   ##
==========================================
+ Coverage   86.54%   86.76%   +0.22%     
==========================================
  Files           9        9              
  Lines         907      907              
==========================================
+ Hits          785      787       +2     
+ Misses        122      120       -2     
Flag Coverage Δ
py-3.10 86.65% <ø> (+0.22%) ⬆️
py-3.11 86.43% <ø> (ø)
py-3.8 ?
py-3.9 86.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@danielhollas
Copy link
Contributor

Why deprecate 3.8? That is still a version in use by older Linux distros I think, let's not make things more complicated for potential users.

@unkcpz
Copy link
Member Author

unkcpz commented May 30, 2023

Okay, that is true, I was at this repo on other changes and find this from README https://github.com/aiidalab/aiidalab-launch#compatibility.

@danielhollas
Copy link
Contributor

Interesting. TBH I don't really see a reason why this package should follow NEP 29. This package does not depend on the Python scientific ecosystem (numpy et al). On the contrary, since it is a CLI tool, it's likely to be installed system-wide using Linux distribution Python, that is often lagging behind. So I would simply vote for not following NEP 29.

@unkcpz
Copy link
Member Author

unkcpz commented May 30, 2023

Yes, agree. I close this PR.

@unkcpz unkcpz closed this May 30, 2023
@danielhollas danielhollas deleted the chore/action-warnings-and-deprecate-py38 branch May 30, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants