Update dependencies: docker -> 7.0.0 and tabulate -> 0.9.0 #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielhollas
force-pushed
the
deps/update-docker
branch
from
2cf5e7a
to
7cb7f95
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #200 +/- ##
==========================================
- Coverage 86.54% 86.32% -0.22%
==========================================
Files 9 9
Lines 914 914
==========================================
- Hits 791 789 -2
- Misses 123 125 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
danielhollas
commented
Jan 24, 2024
danielhollas
commented
Jan 24, 2024
danielhollas
force-pushed
the
deps/update-docker
branch
from
6da5a19
to
51d7843
Compare
unkcpz
reviewed
Jan 24, 2024
unkcpz
requested changes
Jan 24, 2024
There was a problem hiding this comment.
Thanks @danielhollas!
Just a small request. Can you delete the pre-commit from ci.yml?
Looks like the bug was introduced in version 6.2
You mean 6.1.2 I guess?
|
Thank you for the review. I removed the pre-commit action.
Ah, yep, my bad. |
unkcpz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main goal here is to upgrade to
docker-py==7.0.0which contains a bugfix that I ran into while testing locally with Python 3.12:docker/docker-py#3151
Looks like the bug was introduced in version
6.2which we bumped to in #194 but did not release yet so no users should be affected.Depends on #201