Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor module structure #95

Merged
merged 5 commits into from
Feb 15, 2022
Merged

Refactor module structure #95

merged 5 commits into from
Feb 15, 2022

Conversation

csadorf
Copy link
Member

@csadorf csadorf commented Feb 15, 2022

No description provided.

@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #95 (2adcc33) into main (31e9d2a) will increase coverage by 0.48%.
The diff coverage is 93.36%.

❗ Current head 2adcc33 differs from pull request most recent head d57d4a9. Consider uploading reports for the commit d57d4a9 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
+ Coverage   86.04%   86.52%   +0.48%     
==========================================
  Files           5        9       +4     
  Lines         781      809      +28     
==========================================
+ Hits          672      700      +28     
  Misses        109      109              
Flag Coverage Δ
py-3.10 86.40% <93.36%> (+0.48%) ⬆️
py-3.7 85.95% <93.17%> (+0.52%) ⬆️
py-3.8 86.35% <93.33%> (+0.49%) ⬆️
py-3.9 86.47% <93.33%> (+0.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiidalab_launch/core.py 100.00% <ø> (+7.31%) ⬆️
aiidalab_launch/__main__.py 80.26% <90.00%> (-1.44%) ⬇️
aiidalab_launch/instance.py 91.35% <91.35%> (ø)
aiidalab_launch/profile.py 94.73% <94.73%> (ø)
aiidalab_launch/application_state.py 97.82% <97.82%> (ø)
aiidalab_launch/config.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85e6234...d57d4a9. Read the comment docs.

@csadorf csadorf changed the base branch from main to tests/revise-instance-life-cycle-test February 15, 2022 10:17
@csadorf csadorf changed the base branch from tests/revise-instance-life-cycle-test to main February 15, 2022 10:20
@csadorf csadorf force-pushed the refactor-module-structure branch 2 times, most recently from 6a6a01a to 92fa315 Compare February 15, 2022 12:42
@csadorf csadorf merged commit caf5db9 into main Feb 15, 2022
@csadorf csadorf deleted the refactor-module-structure branch February 15, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant