Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean the remote workdir as default and provide checkbox for not clean up #370

Closed
unkcpz opened this issue Mar 20, 2023 · 2 comments · Fixed by #497
Closed

Clean the remote workdir as default and provide checkbox for not clean up #370

unkcpz opened this issue Mar 20, 2023 · 2 comments · Fixed by #497
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@unkcpz
Copy link
Member

unkcpz commented Mar 20, 2023

Is your feature request related to a problem? Please describe.
In the THEOS testing server, the storage space of active user increased dramatically. The issue comes from that the calculation folder is not cleaned up if run in localhost.

Describe the solution you'd like
Clean up the remote workdir if the calculation finished successfully, provide the widget to tick the option to turn off clean up.

@unkcpz unkcpz added the enhancement New feature or request label Mar 20, 2023
@unkcpz unkcpz self-assigned this Apr 4, 2023
@unkcpz unkcpz added this to the v2023.10.0 milestone Apr 4, 2023
@AndresOrtegaGuerrero
Copy link
Member

I think that this feature could be a checkbox in the AdvancedSetting tab

@mbercx
Copy link
Member

mbercx commented Apr 19, 2023

Hmm, just off the top of my head: clean_workdir is an input of each work chain, and is not dynamically changed if the work chain fails. So I guess keep this to False (which will be default from the next release), and then use a similar implementation as in the on_terminated to clean if successful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants