Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clean-up button to control the remote work directory clean #497

Merged
merged 4 commits into from
Oct 9, 2023

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Oct 6, 2023

fixes #370

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Attention: 113 lines in your changes are missing coverage. Please review.

Comparison is base (6d04345) 55.82% compared to head (3d511a3) 77.29%.
Report is 29 commits behind head on main.

❗ Current head 3d511a3 differs from pull request most recent head e82b9c0. Consider uploading reports for the commit e82b9c0 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #497       +/-   ##
===========================================
+ Coverage   55.82%   77.29%   +21.47%     
===========================================
  Files          27       44       +17     
  Lines        2370     3127      +757     
===========================================
+ Hits         1323     2417     +1094     
+ Misses       1047      710      -337     
Flag Coverage Δ
python-3.10 77.29% <91.42%> (+21.47%) ⬆️
python-3.8 77.33% <91.42%> (+21.46%) ⬆️
python-3.9 77.33% <91.42%> (+21.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/aiidalab_qe/app/configuration/workflow.py 100.00% <100.00%> (ø)
src/aiidalab_qe/app/structure/__init__.py 89.83% <100.00%> (+53.34%) ⬆️
src/aiidalab_qe/app/submission/sssp.py 43.47% <100.00%> (+2.17%) ⬆️
src/aiidalab_qe/app/utils/__init__.py 100.00% <100.00%> (ø)
src/aiidalab_qe/common/__init__.py 100.00% <ø> (ø)
src/aiidalab_qe/common/node_view.py 42.64% <ø> (ø)
src/aiidalab_qe/common/setup_codes.py 42.74% <100.00%> (ø)
src/aiidalab_qe/plugins/bands/__init__.py 100.00% <100.00%> (ø)
src/aiidalab_qe/plugins/bands/setting.py 100.00% <100.00%> (ø)
src/aiidalab_qe/plugins/pdos/__init__.py 100.00% <100.00%> (ø)
... and 28 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mikibonacci mikibonacci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi jason, is it intended to leave some space between the checkbox and the description?

Screenshot from 2023-10-09 11-41-17

@unkcpz
Copy link
Member Author

unkcpz commented Oct 9, 2023

Hi jason, is it intended to leave some space between the checkbox and the description?

Good point, I didn't expect the space are so large. I intended to use the px instead of the %. I polished it a bit. We need anyway go though all the layout and make everything look compact, but that is a task for the future.

I opened an issue for it #499

@unkcpz unkcpz merged commit 967c3f8 into main Oct 9, 2023
5 of 6 checks passed
@unkcpz unkcpz deleted the fix/370/cleanup-workflow branch October 9, 2023 09:56
@AndresOrtegaGuerrero
Copy link
Member

@mikibonacci By default the check box is always on ? This could be problematic if an user missed this and wanted to do postprocessing with some files not saved

@unkcpz
Copy link
Member Author

unkcpz commented Oct 10, 2023

This could be problematic if an user missed this and wanted to do postprocessing with some files not saved

Then, it will be an "advanced" user and he is supposed to go to the advance setting and un-tick it I assume?

@unkcpz
Copy link
Member Author

unkcpz commented Oct 16, 2023

As we discussed in the last AiiDAlab meeting, we agree that the workchain should not be cleaned by default. I'll open a PR for it after.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean the remote workdir as default and provide checkbox for not clean up
3 participants