Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accelerate the loading speed of the App #455

Closed
unkcpz opened this issue Sep 4, 2023 · 4 comments
Closed

Accelerate the loading speed of the App #455

unkcpz opened this issue Sep 4, 2023 · 4 comments
Labels
enhancement New feature or request
Milestone

Comments

@unkcpz
Copy link
Member

unkcpz commented Sep 4, 2023

Opening the app takes a quite long time, check https://github.com/ispg-group/aiidalab-ispg to see how it benchmarks the time of loading and benchmark to find the bottleneck widgets.

@unkcpz unkcpz added the enhancement New feature or request label Sep 4, 2023
@unkcpz unkcpz added this to the v2023.10.0 milestone Sep 4, 2023
@unkcpz
Copy link
Member Author

unkcpz commented Sep 18, 2023

@superstar54, I may don't have time to look at this this week. Since this is a critical blocker of the release of 23.10, could you find time to investigate it a bit?
As we discussed last week, you can try to update aiida-core which has @danielhollas's import improve implementation. I think the delay may also come from optimade widget, you can try to comment it out and test the load time.

Since we have moved out the app class as an independent one, I guess it is easy to benchmark by running time python -c "from aiidalab_qe.app import App; App(qe_auto_setup=True)"

@danielhollas
Copy link
Contributor

@superstar54 I'd recommend looking at this topic on Discourse to see how I benchmarked import time with cProfile
https://aiida.discourse.group/t/why-is-aiidalab-base-widget-import-so-slow/32

As we discussed last week, you can try to update aiida-core which has @danielhollas's import improve implementation.

Note that you'll have to pull the latest main branch for this, my improvements have not been released in official version yet.

I would also recommend implementing #453, which can speed things up a lot, especially for users with a lot of finished workflows.

@superstar54
Copy link
Member

I would also recommend implementing #453, which can speed things up a lot, especially for users with a lot of finished workflows.

@danielhollas Thanks. I looked at the code of WorkChainSelector. There is a big performance issue in the for loop. I will try to improve it. If it does not work, I will try to use your approach.

@unkcpz
Copy link
Member Author

unkcpz commented Oct 4, 2023

I think we can close this for the moment after @superstar54's work on #473

@unkcpz unkcpz closed this as completed Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants