Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use label in WorkChainSelector #473

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Use label in WorkChainSelector #473

merged 1 commit into from
Sep 19, 2023

Conversation

superstar54
Copy link
Member

@superstar54 superstar54 commented Sep 19, 2023

Related to #455 .

This PR avoids loading nodes in the WorkChainSelecter.

On my computer, there are 81 QeAppWorkChain processes.

Time to refresh the WorkChainSelecter

Old This PR
19 s 0.15 s

Time to load QeApp

Old This PR
22 s 7 s

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage: 23.52% and project coverage change: +0.07% 🎉

Comparison is base (b4b5a72) 63.65% compared to head (d146f30) 63.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #473      +/-   ##
==========================================
+ Coverage   63.65%   63.73%   +0.07%     
==========================================
  Files          40       40              
  Lines        2710     2702       -8     
==========================================
- Hits         1725     1722       -3     
+ Misses        985      980       -5     
Flag Coverage Δ
python-3.10 63.73% <23.52%> (+0.07%) ⬆️
python-3.8 63.77% <23.52%> (+0.07%) ⬆️
python-3.9 63.77% <23.52%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/aiidalab_qe/app/submission/__init__.py 73.12% <7.69%> (-3.55%) ⬇️
src/aiidalab_qe/common/process.py 81.53% <75.00%> (+15.25%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@unkcpz unkcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, it is clever to move the label generator to submission. Looks all good to me. Thanks!

@unkcpz unkcpz merged commit 855b08f into main Sep 19, 2023
13 checks passed
@unkcpz unkcpz deleted the improve_workchain_selector branch September 19, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants