Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accelerate the docker image by pre-download the pseudos libraries #490

Closed
unkcpz opened this issue Sep 26, 2023 · 1 comment · Fixed by #524
Closed

Accelerate the docker image by pre-download the pseudos libraries #490

unkcpz opened this issue Sep 26, 2023 · 1 comment · Fixed by #524
Labels
enhancement New feature or request

Comments

@unkcpz
Copy link
Member

unkcpz commented Sep 26, 2023

aiidateam/aiida-pseudo#135 is merged, after the new version of aiida-pseudo is released we can move the download part to dockerfile and make the before-notebook.d script light and fast. Further benchmark is required to see how much time we gained by this change.

@mbercx any idea to make a patch (or minor?) release of aiida-pseudo?

@unkcpz unkcpz added the enhancement New feature or request label Sep 26, 2023
@mbercx
Copy link
Member

mbercx commented Sep 26, 2023

Ah yes, we can do a quick minor release. 👍

unkcpz added a commit that referenced this issue Nov 8, 2023
fixes #490

The relevant changes needed are:

pinging the aiida-pseudo version.
Refactoring the methods in setup_pseudos.py to support flexible parameter passing.
Note that from the test all 8 pseudos seems to only save ~10s but in the place where the network condition is bad, this is very helpful.

---------

Co-authored-by: superstar54 <xingwang1991@gmail.com>
unkcpz added a commit that referenced this issue Nov 8, 2023
fixes #490

In this commit, we pinging the aiida-pseudo version to use the
--download-only option to download the pseudo archive to the container
for quick installation when the container first time start.
Note that from the test all 8 pseudos seems to only save ~10s but in the place where the network condition is bad, this is very helpful.

Further more Refactoring the methods in setup_pseudos.py to support flexible parameter passing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants