Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the clarity of unit test fixtures #533

Open
unkcpz opened this issue Oct 24, 2023 · 3 comments
Open

Improve the clarity of unit test fixtures #533

unkcpz opened this issue Oct 24, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@unkcpz
Copy link
Member

unkcpz commented Oct 24, 2023

The unit test fixtures are a bit messy at the moment, the performance is not good as well. Some fixtures to create app object and step objects seems redundant. We need to set the app as a session with a clear tear-down process to reset, instead creat a new object and setting parameters from the beginning.

@superstar54 let's try to set a pair coding session between two of us to tidy things up.

@unkcpz unkcpz added the enhancement New feature or request label Oct 24, 2023
@unkcpz
Copy link
Member Author

unkcpz commented Jan 10, 2024

I think this issue become a high priority after the stable release and more qeapp plugins start shaping.
Can I assign this to you @superstar54? Since most nice unit tests are brought to the code base with the plugin design.

@unkcpz unkcpz assigned superstar54 and unassigned superstar54 Jan 10, 2024
@unkcpz
Copy link
Member Author

unkcpz commented Jan 19, 2024

Hi @superstar54, can this be assigned to you? I think the plugins would benifit from having testing. Clear fixtures can help developers to writing sustainable plugins.

@superstar54
Copy link
Member

superstar54 commented Feb 1, 2024

To make the unit test more clear. Here are the catalogs for the test:

  • Setting GUI

    • set
    • reset
    • load previous results
  • Result GUI

    • mock workchain output
  • Workchain

    • main app
    • plugin related

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

2 participants