Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button to display Results panel #585

Closed
mikibonacci opened this issue Dec 19, 2023 · 2 comments
Closed

Add button to display Results panel #585

mikibonacci opened this issue Dec 19, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@mikibonacci
Copy link
Member

The following is from a user's feedback:

"It would be nice to add a Display results button near the Kill workchain one.
This will be more intuitive for a user, instead of wait the automatic display.
The user may think that something went wrong and the workchain failed."

Indeed, he guessed that his workchain was failed, but actually was finished_ok, and still loading results.

Pinning @unkcpz and @danielhollas for some feedback about this.

@mikibonacci mikibonacci added the enhancement New feature or request label Dec 19, 2023
@unkcpz
Copy link
Member

unkcpz commented Dec 19, 2023

I remember @danielhollas mentioned his app didn't load the workchain viewer automatically but only show when a button was clicked, correct me if I am wrong.
I think a reasonable behavior would be always showing a workflow overview showing the current input/output summaries plus the state of the current workchain.

I also remember @superstar54 had a very interesting demo showing how to use aiida engine monitor to show the updated result, but that is for the long term improvement.
For the moment, I think we should adapt the way @danielhollas used for his app.

@unkcpz unkcpz added this to the v2024.4.0 milestone Dec 19, 2023
@superstar54
Copy link
Member

I just discussed with @mikibonacci that this problem most probably happens in the Phonon plugin with a huge number of sub-processes, as reported in aiidalab/aiidalab-widgets-base#584. We believe this should be fixed in aiidalab/aiidalab-widgets-base#583.

Besides, now there will be information on the job state close to the kill button, as implemented in #648, so the user will not be confused anymore about the job's state.

Thus I closed this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants