Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide kill button when the process is done #648

Merged
merged 7 commits into from
Apr 9, 2024

Conversation

superstar54
Copy link
Member

@superstar54 superstar54 commented Mar 26, 2024

fix #605 and #606
Hide the "Kill workchain" button when the workchain is done (finished or excepted).

qeapp-kill-button.mp4

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 75.68%. Comparing base (f63da7d) to head (25e0168).
Report is 52 commits behind head on main.

❗ Current head 25e0168 differs from pull request most recent head cc2713d. Consider uploading reports for the commit cc2713d to get more accurate results

Files Patch % Lines
src/aiidalab_qe/app/result/__init__.py 66.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #648      +/-   ##
==========================================
- Coverage   80.73%   75.68%   -5.05%     
==========================================
  Files          49       60      +11     
  Lines        3415     4331     +916     
==========================================
+ Hits         2757     3278     +521     
- Misses        658     1053     +395     
Flag Coverage Δ
python-3.10 75.68% <66.66%> (-5.05%) ⬇️
python-3.8 ?
python-3.9 75.71% <66.66%> (-5.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superstar54 superstar54 linked an issue Mar 26, 2024 that may be closed by this pull request
@mikibonacci
Copy link
Member

Hi @superstar54 , thanks for the fixings! for me is fine to merge

@superstar54
Copy link
Member Author

Hi @superstar54 , thanks for the fixings! for me is fine to merge

@mikibonacci , thanks for the review! Could you approve the PR?

@mikibonacci mikibonacci enabled auto-merge (squash) April 9, 2024 08:31
Copy link
Member

@mikibonacci mikibonacci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@superstar54 superstar54 merged commit 86f4aac into aiidalab:main Apr 9, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants