Set installed traitlets of pseudo/qe install widget when it's done #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unkcpz
changed the title
unkcpz
force-pushed
the
fix/pseudo-installed
branch
from
5203ea4
to
7b7d40e
Compare
csadorf
suggested changes
Aug 8, 2022
aiidalab_qe/sssp.py
Outdated
| @@ -102,6 +102,7 @@ def _refresh_installed(self): | |||
| self.set_trait("error", str(error)) | |||
| self.set_message(str(error)) | |||
| else: | |||
| self.set_trait("installed", True) | |||
There was a problem hiding this comment.
To be safe I'd recommend:
Suggested change
| self.set_trait("installed", True) | |
| self.set_trait("installed", not bool(pseudos_to_install())) |
There was a problem hiding this comment.
Good advice! If all the libraries are install by hands bool(pseudos_to_install()) will be False empty list.
unkcpz
force-pushed
the
fix/pseudo-installed
branch
from
f252388
to
e3ec04b
Compare
csadorf
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #261