Fail if process exits with non-zero status #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unkcpz
approved these changes
Sep 19, 2022
unkcpz
reviewed
Sep 19, 2022
Comment on lines
+930
to
+933
| elif ( | ||
| process_state in (ProcessState.EXCEPTED, ProcessState.KILLED) | ||
| or self.process.is_failed | ||
| ): |
There was a problem hiding this comment.
Are these all cases of not self.process.is_finished_ok? But this is more explicit and all good from my side.
There was a problem hiding this comment.
Yes, as far as I know. Thanks!
|
Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on aiidalab/aiidalab-widgets-base#336, see discussion there.
(I tested this in my own app, but suppose it works here too)