Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New version for src workchain #300

Merged
merged 4 commits into from
Nov 1, 2022
Merged

New version for src workchain #300

merged 4 commits into from
Nov 1, 2022

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Oct 10, 2022

fixes #298

@unkcpz unkcpz marked this pull request as draft October 10, 2022 10:48
@unkcpz
Copy link
Member Author

unkcpz commented Oct 10, 2022 •
edited
Loading

blocked by mbarkhau/bumpver#190

@unkcpz unkcpz marked this pull request as ready for review October 16, 2022 11:54
@unkcpz unkcpz removed the pr/blocked label Oct 16, 2022
@unkcpz
Copy link
Member Author

unkcpz commented Oct 16, 2022

This PR also need to be merged before the Mig2.x PR, since the aiidalab_qe_workchain from src folder will detect using version 1.0 and use the old dependency which forbids the installation.

@unkcpz unkcpz changed the title New version for src workchain, but blocked by bumpver New version for src workchain ~~but blocked by bumpver~~ Oct 19, 2022
@unkcpz unkcpz changed the title New version for src workchain ~~but blocked by bumpver~~ New version for src workchain Oct 19, 2022
superstar54
superstar54 approved these changes Nov 1, 2022
View reviewed changes
Copy link
Member

@superstar54 superstar54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@unkcpz unkcpz merged commit 60fa5e7 into master Nov 1, 2022
@unkcpz unkcpz deleted the fix/298/src-qe-wc-version branch November 1, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superstar54 superstar54 superstar54 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The aiidalab-qe-workchain version is not updated when the QE app is updated via the app store
2 participants
@unkcpz @superstar54