Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to support uuid traitlets #307

Closed
wants to merge 2 commits into from
Closed

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Oct 21, 2022

after aiidalab/aiidalab-widgets-base#375, these changes are needed here.

@danielhollas
Copy link
Contributor

danielhollas commented Nov 2, 2022

@unkcpz thanks to this PR I was able to adapt my app quite quickly, thanks!

I think you also need to fix the CalcJobNodeViewer in widgets.py, see the corresponding changes in my app, which reuses this code verbatim.

https://github.com/ispg-group/aiidalab-ispg/pull/80/files#diff-7de888163d19a15c2c2a188fb8397b5a6b99e627e73b33bdd70188d3bb87b1eb

I wonder if the CalcJobNodeViewer and its dependencies shouldn't be merged to AWB as it is quite useful, and there seems to be some overlap with existing widgets in aiidalab_widgets_base/process.py

@unkcpz
Copy link
Member Author

unkcpz commented Nov 2, 2022

I wonder if the CalcJobNodeViewer and its dependencies shouldn't be merged to AWB as it is quite useful, and there seems to be some overlap with existing widgets in aiidalab_widgets_base/process.py

I am fully on it. I think the initial idea from @csadorf is we need to first have the widget implemented in App and after finding it useful and having APIs well-defined, move the widget to the aiidalab-widgets-base. The widgets shared by qeApp and your app match this condition. I'll decouple it from here.

@unkcpz unkcpz added this to the AiiDA 2.x milestone Nov 7, 2022
@unkcpz
Copy link
Member Author

unkcpz commented Nov 10, 2022

Since this is anyway needed and tested in the Mig2.x. I close this PR and put all things to #271

@unkcpz unkcpz closed this Nov 10, 2022
@unkcpz unkcpz deleted the uuid-traitlets-support branch November 10, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants