Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QEApp Documentation #414

Merged
merged 80 commits into from
Jul 27, 2023
Merged

QEApp Documentation #414

merged 80 commits into from
Jul 27, 2023

Conversation

edan-bainglass
Copy link
Member

@edan-bainglass edan-bainglass commented Jun 9, 2023

This PR regards the development of a ReadTheDocs page for the Quantum ESPRESSO App.

The initial state of the documentation was derived from AiiDAlab and a previous tutorial for the app. Modifications are in progress.

Current tasks:

  • Shift more towards linear story telling - Edan
  • Restructure the tutorial - Edan
  • Clean up How-to guides - Edan
  • Expand How-to guides - Xing
  • Update to use the aiidalab-docker-stack/qe image @unkcpz

The above are an overview. More information may be supplied here over the course of the PR.

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: +4.82% 🎉

Comparison is base (d210b45) 52.63% compared to head (6012b7f) 57.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #414      +/-   ##
==========================================
+ Coverage   52.63%   57.45%   +4.82%     
==========================================
  Files          17       17              
  Lines        1879     2534     +655     
==========================================
+ Hits          989     1456     +467     
- Misses        890     1078     +188     
Flag Coverage Δ
python-3.10 57.45% <ø> (+4.82%) ⬆️
python-3.8 57.50% <ø> (+4.81%) ⬆️
python-3.9 57.50% <ø> (+4.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@unkcpz
Copy link
Member

unkcpz commented Jun 9, 2023

Hi @edan-bainglass, thanks a lot! This is a super important improvement for the qeapp.

You are using windows system on your laptop correct? Can you test if that possible to run the container with https://docs.docker.com/desktop/install/windows-install/? If so, I think it would be nice to use this to start the container.

@edan-bainglass
Copy link
Member Author

edan-bainglass commented Jun 9, 2023

@unkcpz do you want to see if it runs from Windows native, or from WSL?

Also, what "Update to use the aiidalab-docker-stack/qe image" about?

Which image is used presently that we need to update to this one? And also, is this the most current one? I thought we're using aiidalab/full-stack going forward?

@unkcpz unkcpz mentioned this pull request Jun 14, 2023
5 tasks
@unkcpz unkcpz force-pushed the docs branch 4 times, most recently from a8ab26d to f9742f2 Compare June 14, 2023 09:52
@unkcpz
Copy link
Member

unkcpz commented Jun 19, 2023

As we discussed offline last week.

@unkcpz do you want to see if it runs from Windows native, or from WSL?

The docker desktop from windows native https://docs.docker.com/desktop/install/windows-install/. If it can work, that would be very promising.

Also, what "Update to use the aiidalab-docker-stack/qe image" about?
Which image is used presently that we need to update to this one? And also, is this the most current one? I thought we're using aiidalab/full-stack going forward?

I prepare the qe image which has qe and qeapp dependencies installed in the image in advance, which will accelerate the start of QeApp first time. I'll take care of it after this PR merged.

@unkcpz unkcpz marked this pull request as draft June 20, 2023 09:49
@unkcpz
Copy link
Member

unkcpz commented Jun 20, 2023

Hi @edan-bainglass, I convert it to a draft hope you don't mind. Please pin me to review after everything is settled. thanks!

@edan-bainglass
Copy link
Member Author

As we discussed offline last week.

@unkcpz do you want to see if it runs from Windows native, or from WSL?

The docker desktop from windows native https://docs.docker.com/desktop/install/windows-install/. If it can work, that would be very promising.

Also, what "Update to use the aiidalab-docker-stack/qe image" about?
Which image is used presently that we need to update to this one? And also, is this the most current one? I thought we're using aiidalab/full-stack going forward?

I prepare the qe image which has qe and qeapp dependencies installed in the image in advance, which will accelerate the start of QeApp first time. I'll take care of it after this PR merged.

Okay. It works! Note that the link provided at the end of the container installation process does not work as is. I had to manually type http://localhost:<port> in the browser, where port is randomly generated (can be configured at container initialization). I then entered the provided token.

@edan-bainglass edan-bainglass marked this pull request as ready for review July 25, 2023 06:57
@unkcpz
Copy link
Member

unkcpz commented Jul 27, 2023

Thanks @edan-bainglass, it is very well documented! Some minor things are still worth discussing and adding but we can leave it to the documentation day.
I'll merge it anyway.

Thanks again for the great effort, this is very very helpful for the QeApp!

@unkcpz unkcpz merged commit 72d9390 into main Jul 27, 2023
13 checks passed
@unkcpz unkcpz deleted the docs branch July 27, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants