Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: using the new propared qe image #434

Merged
merged 3 commits into from
Aug 14, 2023
Merged

Doc: using the new propared qe image #434

merged 3 commits into from
Aug 14, 2023

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Aug 3, 2023

No description provided.

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (21b8283) 52.61% compared to head (370c15e) 52.61%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #434   +/-   ##
=======================================
  Coverage   52.61%   52.61%           
=======================================
  Files          17       17           
  Lines        2068     2068           
=======================================
  Hits         1088     1088           
  Misses        980      980           
Flag Coverage Δ
python-3.10 52.61% <ø> (ø)
python-3.8 52.66% <ø> (ø)
python-3.9 52.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

I don't see a need to burden this page. I find it more appropriate to add these details to the launch page, which already discusses profiles. See next commit.
Moved details previously in the docker page to the launch page.
Copy link
Member

@edan-bainglass edan-bainglass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my two commits. Everything else looks good to me. If no issues with my change, feel free to merge.

@unkcpz
Copy link
Member Author

unkcpz commented Aug 14, 2023

Okay, although I move the paragraph out intently. But that's for sure to be discussed. Let's use your organization of the sections and content, just keep the new content added. We can discuss how to re-organize during the documentation day.

@unkcpz unkcpz merged commit 823a6fb into main Aug 14, 2023
13 checks passed
@unkcpz unkcpz deleted the doc/qe-edge-image branch August 14, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants