-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to App widget and call from notebook #442
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #442 +/- ##
==========================================
- Coverage 56.52% 55.91% -0.62%
==========================================
Files 26 27 +1
Lines 2321 2375 +54
==========================================
+ Hits 1312 1328 +16
- Misses 1009 1047 +38
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
@superstar54 you mentioned the dlink may not necessary. I think it depends on the scenario and if you can decouple step widgets by adding another "data" layer in between. If you want to make such a change, please make a dedicated PR for that. |
- f-x
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
For the test purpose of #428 proposed by @superstar54, we think moving the code from
qe.ipynb
into a module and creating an App class would make it not only more maintainable and easy for integrate unit test of the whole app as an widget.