-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move docker stack build from docker stack to aiidalab-qe #449
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #449 +/- ##
=======================================
Coverage 70.45% 70.45%
=======================================
Files 42 42
Lines 2955 2955
=======================================
Hits 2082 2082
Misses 873 873
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
1d06a63
to
f272c90
Compare
@@ -347,7 +347,7 @@ def _get_pseudos_family(self, pseudo_family: str) -> orm.Group: | |||
.one()[0] | |||
) | |||
except exceptions.NotExistent as exception: | |||
raise ValueError( | |||
raise exceptions.NotExistent( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: This change is separated as a single commit 6c194c6. The exception needs to be propagated up and not raise, otherwise if the pseudopotential library not installed, the app will crash when structure selected and confirm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, wow, I wasn't expecting the PR to look so big.
Do we need all this complicated machinery? I thought we just made a tiny docker file + 2 bash scripts.
I believe it shouldn't be as complicated as the base repository where there are multiple stages/versions.
If you want, I can try to make a concurrent PR with what I have in mind.
I try to use all the state-of-art pr review feature from what I introduced to
Sure, please try it. But I am doubt there is a simple one with all the useful features exists here, see the checkboxes below:
|
d58f821
to
d955b56
Compare
78a3165
to
15e07d9
Compare
e2d608a
to
202d621
Compare
Hi @yakutovicha, I deployed the macOS action runner on PSI Machine with Marnik, and all tests are passed. I believe to support ARM64 especially run on self-hosted runner on macOS the complicities here are difficult to avoid. But if your app doesn't need support arm64, then it is possible to have a light CI to build and test, you can do the test on your app. Feel free to have a go-through on the implementation, if you have no objection I'll merge it tonight. |
3566165
to
f0e97fa
Compare
f0e97fa
to
d0cc7ea
Compare
Attempt to solve aiidalab/aiidalab-docker-stack#406
I adapt most of the codes I used in
aiidalab-docker-stack
, except in this repo, I calldocker buildx bake
directly instead of usingdoit
script.It reveals that with this implementation, the integration test can be easily run with the image build. Also, provide a preview container on ghcr for immediate test of new feature implementation.