-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plugin entry point to workchain #458
Conversation
namespace_options={"required": False}, | ||
) | ||
spec.exit_code( | ||
404 + 1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
? 😸
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #458 +/- ##
==========================================
+ Coverage 56.68% 59.73% +3.04%
==========================================
Files 28 36 +8
Lines 2415 2826 +411
==========================================
+ Hits 1369 1688 +319
- Misses 1046 1138 +92
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Very clear now, thanks!
# I removed the `validate_properties`, because the `properties` to be | ||
# calculated are not fixed anymore. It depends on the installed plugins. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this before merging.
Wait, seems there is a failed test, and it is caused by the plugin design. You can go and check the screenshot of the module loading failure in https://github.com/aiidalab/aiidalab-qe/actions/runs/6085956137?pr=458 (By download the artifact screenshot) |
Thanks for pointing out this. It was solved by adding |
This PR uses
bands
property as an example to implement plugin design into the workchain.plugins
andcommon
folders out from the app. This is also reasonable since both of them do not belong to the app.run_plugin
method to run all plugins in parallel.scf
foder betweenbands
andpdos
.