Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge advanced setting #461

Merged
merged 3 commits into from
Sep 8, 2023
Merged

Merge advanced setting #461

merged 3 commits into from
Sep 8, 2023

Conversation

superstar54
Copy link
Member

This PR

  • Move Pseudo selector and setter to advanced setting
  • add protocol to Pseudo selector and link it with the protocol from the workflow.

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch coverage: 49.66% and project coverage change: -0.13% ⚠️

Comparison is base (c3ef810) 56.69% compared to head (acc99aa) 56.57%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #461      +/-   ##
==========================================
- Coverage   56.69%   56.57%   -0.13%     
==========================================
  Files          36       39       +3     
  Lines        2593     2671      +78     
==========================================
+ Hits         1470     1511      +41     
- Misses       1123     1160      +37     
Flag Coverage Δ
python-3.10 56.57% <49.66%> (-0.13%) ⬇️
python-3.8 56.61% <49.66%> (-0.13%) ⬇️
python-3.9 56.61% <49.66%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/aiidalab_qe/app/configuration/__init__.py 30.58% <0.00%> (-1.38%) ⬇️
src/aiidalab_qe/app/main.py 28.00% <ø> (+1.07%) ⬆️
src/aiidalab_qe/workflows/__init__.py 52.98% <0.00%> (+2.98%) ⬆️
src/aiidalab_qe/plugins/pdos/result.py 14.28% <14.28%> (ø)
src/aiidalab_qe/app/submission/__init__.py 70.40% <60.00%> (-0.30%) ⬇️
src/aiidalab_qe/app/configuration/advanced.py 88.46% <72.72%> (-1.20%) ⬇️
src/aiidalab_qe/plugins/pdos/workchain.py 92.85% <92.85%> (ø)
src/aiidalab_qe/app/configuration/pseudos.py 88.34% <95.45%> (+0.66%) ⬆️
src/aiidalab_qe/app/configuration/workflow.py 100.00% <100.00%> (ø)
src/aiidalab_qe/plugins/pdos/__init__.py 100.00% <100.00%> (ø)
... and 2 more

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@unkcpz
Copy link
Member

unkcpz commented Sep 8, 2023

Looks all good, thanks!

@superstar54 superstar54 merged commit 44f01c5 into main Sep 8, 2023
13 checks passed
@superstar54 superstar54 deleted the merge_advanced_setting branch September 8, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants