Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use get and set for WorkChain settings #464

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Conversation

superstar54
Copy link
Member

@superstar54 superstar54 commented Sep 14, 2023

The get_configuration_parameters method of ConfigureQeAppWorkChainStep is hard coded. In principle, it should only need to call the method from sub-settings (plugin's panel). e.g

        workchain_settings = self.workchain_settings.get_setting_parameters()
        advanced_settings = self.advanced_settings.get_setting_parameters()

Same for the setting method.
In this PR, I make this change for the WorkChainSettings. Next PR will be the AdvancedSettings.

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage: 96.96% and project coverage change: +0.19% 🎉

Comparison is base (e758cc5) 62.65% compared to head (0a8805f) 62.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #464      +/-   ##
==========================================
+ Coverage   62.65%   62.84%   +0.19%     
==========================================
  Files          39       39              
  Lines        2664     2662       -2     
==========================================
+ Hits         1669     1673       +4     
+ Misses        995      989       -6     
Flag Coverage Δ
python-3.10 62.84% <96.96%> (+0.19%) ⬆️
python-3.8 62.89% <96.96%> (+0.19%) ⬆️
python-3.9 62.89% <96.96%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
tests/conftest.py 92.85% <ø> (ø)
src/aiidalab_qe/app/configuration/workflow.py 98.11% <96.29%> (+19.32%) ⬆️
src/aiidalab_qe/app/configuration/__init__.py 80.73% <100.00%> (-2.48%) ⬇️
src/aiidalab_qe/app/submission/__init__.py 75.41% <100.00%> (-0.42%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@unkcpz
Copy link
Member

unkcpz commented Sep 14, 2023

In this PR, I make this change for the WorkChainSettings. Next PR will be the AdvancedSettings.

Thanks! The change looks all good. Please go ahead, no need to be a separated PR. You can add more commits here.

@superstar54
Copy link
Member Author

Thanks! The change looks all good. Please go ahead, no need to be a separated PR. You can add more commits here.

Thanks! Then, I will merge this first. Because the change in the advanced setting will be a little bit complicated, it is better to add it in another PR.

@superstar54 superstar54 merged commit 9e68d9b into main Sep 15, 2023
13 checks passed
@superstar54 superstar54 deleted the update_workflow_settings branch September 15, 2023 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants