Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix result tab #468

Merged
merged 2 commits into from
Sep 15, 2023
Merged

fix result tab #468

merged 2 commits into from
Sep 15, 2023

Conversation

superstar54
Copy link
Member

@superstar54 superstar54 commented Sep 15, 2023

Check the plugin design by installing a plugin from another repository: https://github.com/superstar54/aiidalab-qe-eos.
One issue is found: the result panel of eos does not show. This PR fixes it.

Now, we have the first working version of the plugin design. Cheers!

Following work

mush have

  • add more tests, in the old plugin_ui PR, the test coverage is around 80%
  • rewrite set_panel_value for advanced_settings, so we can load data from the process. This needs some improvement from sub-widgets.
  • add a clear doc for the plugin.

Nice to have improvement

  • add entry_point for step 3, allowing the user to set computer resources for their plugin.
  • update the result panel, so that it can combine results from different plugins, e.g. bands and pdos.

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03% ⚠️

Comparison is base (7d84f73) 63.67% compared to head (4196706) 63.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #468      +/-   ##
==========================================
- Coverage   63.67%   63.65%   -0.03%     
==========================================
  Files          40       40              
  Lines        2709     2710       +1     
==========================================
  Hits         1725     1725              
- Misses        984      985       +1     
Flag Coverage Δ
python-3.10 63.65% <0.00%> (-0.03%) ⬇️
python-3.8 63.70% <0.00%> (-0.03%) ⬇️
python-3.9 63.70% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/aiidalab_qe/app/result/workchain_viewer.py 23.07% <0.00%> (-0.13%) ⬇️
src/aiidalab_qe/app/submission/__init__.py 76.66% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@unkcpz unkcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM.

@unkcpz unkcpz merged commit e81919a into main Sep 15, 2023
13 checks passed
@unkcpz unkcpz deleted the final_check branch September 15, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants