Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test for workchain #472

Merged
merged 23 commits into from
Sep 21, 2023
Merged

add test for workchain #472

merged 23 commits into from
Sep 21, 2023

Conversation

superstar54
Copy link
Member

@superstar54 superstar54 commented Sep 18, 2023

This PR adds tests for the QeAppWorkChain, and also includes the plugins: bands and pdos.

The test generates the projection data and bands data, then mounts them to the QeAppWorkChain. The final result is then checked.

@superstar54 superstar54 marked this pull request as draft September 18, 2023 13:58
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch coverage: 95.94% and project coverage change: +6.42% 🎉

Comparison is base (06bcc9d) 64.03% compared to head (b3b2521) 70.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #472      +/-   ##
==========================================
+ Coverage   64.03%   70.45%   +6.42%     
==========================================
  Files          40       42       +2     
  Lines        2736     2955     +219     
==========================================
+ Hits         1752     2082     +330     
+ Misses        984      873     -111     
Flag Coverage Δ
python-3.10 70.45% <95.94%> (+6.42%) ⬆️
python-3.8 70.50% <95.94%> (+6.42%) ⬆️
python-3.9 70.50% <95.94%> (+6.42%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
tests/conftest.py 95.12% <95.13%> (+2.27%) ⬆️
src/aiidalab_qe/app/structure/__init__.py 88.15% <100.00%> (+35.45%) ⬆️
tests/test_plugins_bands.py 100.00% <100.00%> (ø)
tests/test_plugins_pdos.py 100.00% <100.00%> (ø)

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superstar54 superstar54 marked this pull request as ready for review September 20, 2023 13:44
Copy link
Member

@unkcpz unkcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@superstar54 thanks a lot! These are very useful tests. I only have minor requests good to me overall.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
src/aiidalab_qe/app/structure/__init__.py Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
tests/conftest.py Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
tests/conftest.py Show resolved Hide resolved
tests_notebooks/test_qe_app.py Show resolved Hide resolved
Copy link
Member

@unkcpz unkcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work! @superstar54
The chrome test failed with an error, I retrigger it and let's see if it is because of timeout.

@unkcpz unkcpz merged commit 658882b into main Sep 21, 2023
13 checks passed
@unkcpz unkcpz deleted the add_test branch September 21, 2023 09:31
@unkcpz
Copy link
Member

unkcpz commented Sep 21, 2023

🥂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants