Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use uuid for pseudo #475

Merged
merged 3 commits into from
Sep 19, 2023
Merged

use uuid for pseudo #475

merged 3 commits into from
Sep 19, 2023

Conversation

superstar54
Copy link
Member

To reload all parameters in the configuration step, one has to save the configuration_parameters as an extra attribute of the QeAppWorkChain process, which means the parameters can not include an AiiDA Node, so the uuid is used.

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage: 83.87% and project coverage change: +0.68% 🎉

Comparison is base (1c6d957) 63.73% compared to head (67873ff) 64.41%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #475      +/-   ##
==========================================
+ Coverage   63.73%   64.41%   +0.68%     
==========================================
  Files          40       40              
  Lines        2702     2844     +142     
==========================================
+ Hits         1722     1832     +110     
- Misses        980     1012      +32     
Flag Coverage Δ
python-3.10 64.41% <83.87%> (+0.68%) ⬆️
python-3.8 64.46% <83.87%> (+0.68%) ⬆️
python-3.9 64.46% <83.87%> (+0.68%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/aiidalab_qe/app/configuration/advanced.py 88.33% <0.00%> (-1.46%) ⬇️
src/aiidalab_qe/app/configuration/pseudos.py 88.54% <100.00%> (+0.20%) ⬆️
src/aiidalab_qe/workflows/__init__.py 59.74% <100.00%> (+5.19%) ⬆️
tests/test_pseudo.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@unkcpz unkcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The change looks all good, but can you add the implementation to use this for loading the workflow pseudo setting back? The change itself seems not necessary, and I assume when it is used in the actual scenario more change may required, so it makes more sense to look together. You can add commits on top of this.

@superstar54
Copy link
Member Author

can you add the implementation to use this for loading the workflow pseudo setting back?

I added a set_pseudos method to load the parameters back. The test is also updated.

The change itself seems not necessary, and I assume when it is used in the actual scenario more change may required,

The final scenario, which loads all configuration parameters back, can not be done now. It depends on other widgets. It's not good to mix the pseuods with other widgets.

Copy link
Member

@unkcpz unkcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks all good to me.

@unkcpz unkcpz merged commit 1666c56 into main Sep 19, 2023
13 checks passed
@unkcpz unkcpz deleted the use_pseudo_uuid branch September 19, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants