-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reload GUI parameters #485
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #485 +/- ##
==========================================
+ Coverage 75.83% 77.25% +1.41%
==========================================
Files 42 43 +1
Lines 3042 3082 +40
==========================================
+ Hits 2307 2381 +74
+ Misses 735 701 -34
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
@superstar54 , I try using the branch, but i cant upload a previous job it produces an error . On the other hand, i tried creating a new job and setting different parameters, this one works!. With the exception that the Protocol, the Smearing width and Smearing Type were not re-load |
I guess in order to not affect previous jobs maybe you just can check if the yaml file is reachable if not, just set the GUI parameters as default ? |
@AndresOrtegaGuerrero Thanks! I fixed the
I added a check if the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -471,6 +472,16 @@ def _update_builder(self, buildy, max_mpi_per_pool): | |||
else: | |||
self._update_builder(v, max_mpi_per_pool) | |||
|
|||
def set_submission_parameters(self, parameters): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@superstar54, can you add docstring for these newly added functions? I find it quite hard to understand when I first look at it.
Also please try to add as many comment/docstring as possible. Sometimes the design is clear for you but may not be easy to understand for other developers.
This PR allows the QeApp to reload GUI parameters when the user selects a process.
aiida.orm.utils.serialize.serialize
to serialize the GUI parameters as yaml, then save it as an extra of the process node. Then load it using thedeserialize_unsafe
method.advanced_settings
.