Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button to start new workflow #494

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Add button to start new workflow #494

merged 1 commit into from
Oct 4, 2023

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Oct 4, 2023

Looks like this:

image

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Attention: 113 lines in your changes are missing coverage. Please review.

Comparison is base (6d04345) 55.82% compared to head (e23294e) 77.46%.
Report is 27 commits behind head on main.

❗ Current head e23294e differs from pull request most recent head ecc4bad. Consider uploading reports for the commit ecc4bad to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #494       +/-   ##
===========================================
+ Coverage   55.82%   77.46%   +21.64%     
===========================================
  Files          27       44       +17     
  Lines        2370     3124      +754     
===========================================
+ Hits         1323     2420     +1097     
+ Misses       1047      704      -343     
Flag Coverage Δ
python-3.10 77.46% <91.38%> (+21.64%) ⬆️
python-3.8 77.50% <91.38%> (+21.63%) ⬆️
python-3.9 77.50% <91.38%> (+21.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/aiidalab_qe/app/configuration/workflow.py 100.00% <100.00%> (ø)
src/aiidalab_qe/app/structure/__init__.py 89.83% <100.00%> (+53.34%) ⬆️
src/aiidalab_qe/app/submission/sssp.py 43.47% <100.00%> (+2.17%) ⬆️
src/aiidalab_qe/app/utils/__init__.py 100.00% <100.00%> (ø)
src/aiidalab_qe/common/__init__.py 100.00% <ø> (ø)
src/aiidalab_qe/common/node_view.py 42.64% <ø> (ø)
src/aiidalab_qe/common/setup_codes.py 42.74% <100.00%> (ø)
src/aiidalab_qe/plugins/bands/__init__.py 100.00% <100.00%> (ø)
src/aiidalab_qe/plugins/bands/setting.py 100.00% <100.00%> (ø)
src/aiidalab_qe/plugins/pdos/__init__.py 100.00% <100.00%> (ø)
... and 28 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@superstar54 superstar54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fast work. LGTM!

I added one suggestion for the color. You can decide which color you want to use. I approved the PR. There is no need for a second review.

src/aiidalab_qe/common/process.py Outdated Show resolved Hide resolved
@unkcpz unkcpz merged commit 0eaf571 into main Oct 4, 2023
4 of 6 checks passed
@unkcpz unkcpz deleted the fix/xx/start-new-button branch October 4, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants