Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The default value of workdir clean button set to False #509

Merged
merged 4 commits into from
Nov 8, 2023

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Oct 16, 2023

No description provided.

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0da5836) 79.36% compared to head (6646c3f) 79.36%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #509   +/-   ##
=======================================
  Coverage   79.36%   79.36%           
=======================================
  Files          47       47           
  Lines        3251     3251           
=======================================
  Hits         2580     2580           
  Misses        671      671           
Flag Coverage Δ
python-3.10 79.36% <ø> (ø)
python-3.8 79.40% <ø> (ø)
python-3.9 79.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/aiidalab_qe/app/configuration/advanced.py 98.16% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superstar54 superstar54 self-requested a review November 8, 2023 14:14
Copy link
Member

@superstar54 superstar54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@unkcpz unkcpz merged commit b9b86bb into main Nov 8, 2023
17 of 19 checks passed
@unkcpz unkcpz deleted the amend/497/clean-workdir-button-default-false branch November 8, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants