-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix override #517
Fix override #517
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #517 +/- ##
==========================================
+ Coverage 78.87% 78.89% +0.01%
==========================================
Files 45 45
Lines 3205 3208 +3
==========================================
+ Hits 2528 2531 +3
Misses 677 677
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
@AndresOrtegaGuerrero Thanks for the PR. LGTM. Another issue also related to the reset is the kpoints distance. When I select One solution is to remove this line and also the
|
@superstar54 have a look |
@AndresOrtegaGuerrero There are some tests failed. Please check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the tests.
This PR fixes minor issues with Reset_GUI
If you click multiple times override in advanced tab, it can delete the kinds and the input_structure
It can also delete the pseudos and pseudos input_structure.