Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix override #517

Merged
merged 9 commits into from
Oct 20, 2023
Merged

Fix override #517

merged 9 commits into from
Oct 20, 2023

Conversation

AndresOrtegaGuerrero
Copy link
Member

@AndresOrtegaGuerrero AndresOrtegaGuerrero commented Oct 18, 2023

This PR fixes minor issues with Reset_GUI

If you click multiple times override in advanced tab, it can delete the kinds and the input_structure
It can also delete the pseudos and pseudos input_structure.

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (229da06) 78.87% compared to head (b36fef3) 78.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #517      +/-   ##
==========================================
+ Coverage   78.87%   78.89%   +0.01%     
==========================================
  Files          45       45              
  Lines        3205     3208       +3     
==========================================
+ Hits         2528     2531       +3     
  Misses        677      677              
Flag Coverage Δ
python-3.10 78.89% <100.00%> (+0.01%) ⬆️
python-3.8 78.93% <100.00%> (+0.01%) ⬆️
python-3.9 78.93% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/aiidalab_qe/app/configuration/advanced.py 98.16% <100.00%> (+0.02%) ⬆️
tests/configuration/test_advanced.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superstar54
Copy link
Member

superstar54 commented Oct 18, 2023

@AndresOrtegaGuerrero Thanks for the PR. LGTM.

Another issue also related to the reset is the kpoints distance. When I select protocol as fast, then go to the advanced panel, I click and then unselected the override checkbox. The kpoints distance is now generated from the moderate protocol. Could you also fix this in this PR

One solution is to remove this line and also the _default_protocol for the advanced setting. What do you think?

self.protocol = self._default_protocol

@AndresOrtegaGuerrero
Copy link
Member Author

@superstar54 have a look

@superstar54
Copy link
Member

@AndresOrtegaGuerrero There are some tests failed. Please check.

Copy link
Member

@superstar54 superstar54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the tests.

@superstar54 superstar54 merged commit 0006ac2 into main Oct 20, 2023
19 checks passed
@superstar54 superstar54 deleted the fix_override branch October 20, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants