Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/result multiple plugins #545

Merged
merged 10 commits into from
Nov 3, 2023
Merged

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Nov 2, 2023

Rebase PR #522 to main, supports

  • showing the result from multiple plugins.
  • only shows the result panel when it is available.

One can use the workchain_labels to specify which plugins (outputs) are needed for this result panel. For example, the electronic_structure result panel needs pdos and bands.

class Result(ResultPanel):
    title = "Electronic Structure"
    workchain_labels = ["bands", "pdos"]

@unkcpz
Copy link
Member Author

unkcpz commented Nov 2, 2023

Rebased to main, please have a look and test @superstar54.

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (368cbe6) 78.92% compared to head (5008512) 79.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #545      +/-   ##
==========================================
+ Coverage   78.92%   79.07%   +0.14%     
==========================================
  Files          45       47       +2     
  Lines        3213     3211       -2     
==========================================
+ Hits         2536     2539       +3     
+ Misses        677      672       -5     
Flag Coverage Δ
python-3.10 79.07% <94.64%> (+0.14%) ⬆️
python-3.8 79.11% <94.64%> (+0.14%) ⬆️
python-3.9 79.11% <94.64%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/aiidalab_qe/common/panel.py 86.95% <100.00%> (+0.28%) ⬆️
src/aiidalab_qe/plugins/bands/result.py 94.73% <100.00%> (+0.29%) ⬆️
...idalab_qe/plugins/electronic_structure/__init__.py 100.00% <100.00%> (ø)
src/aiidalab_qe/plugins/pdos/result.py 92.95% <100.00%> (+0.10%) ⬆️
tests/test_plugins_bands.py 100.00% <ø> (ø)
tests/test_plugins_electronic_structure.py 100.00% <100.00%> (ø)
tests/test_plugins_pdos.py 100.00% <ø> (ø)
tests/test_result.py 100.00% <ø> (ø)
...aiidalab_qe/plugins/electronic_structure/result.py 79.26% <94.44%> (ø)
src/aiidalab_qe/app/result/workchain_viewer.py 57.40% <88.88%> (-2.06%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@superstar54 superstar54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a quick test and also compared it with #522. LGTM!

@unkcpz unkcpz merged commit 7224f00 into main Nov 3, 2023
17 of 19 checks passed
@unkcpz unkcpz deleted the feature/result_multiple_plugins branch November 3, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants