Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix layout of the setting tab title for bands and pdos #555

Merged
merged 3 commits into from
Nov 9, 2023

Conversation

superstar54
Copy link
Member

@superstar54 superstar54 commented Nov 9, 2023

forward to #528

Screenshot from 2023-11-09 11-20-18

Copy link
Member

@unkcpz unkcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to call it "Workflow settings" for the first tab? In order to align with the "Advanced Settings"?

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (56f403d) 80.73% compared to head (36c4af0) 80.73%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #555   +/-   ##
=======================================
  Coverage   80.73%   80.73%           
=======================================
  Files          49       49           
  Lines        3415     3415           
=======================================
  Hits         2757     2757           
  Misses        658      658           
Flag Coverage Δ
python-3.10 80.73% <100.00%> (ø)
python-3.8 80.77% <100.00%> (ø)
python-3.9 80.77% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/aiidalab_qe/app/configuration/__init__.py 98.79% <100.00%> (ø)
src/aiidalab_qe/plugins/bands/setting.py 100.00% <100.00%> (ø)
src/aiidalab_qe/plugins/pdos/setting.py 97.36% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@unkcpz unkcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @superstar54

We discussed offline and agreed on changing the tab name from "Workflow" to "Basic settigs".

@superstar54 superstar54 merged commit 4540a86 into main Nov 9, 2023
12 of 13 checks passed
@superstar54 superstar54 deleted the fix/528/layout branch November 9, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants