-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use the function itself instead of the decorated calcfunction #556
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice i didnt know we could use it like that!
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #556 +/- ##
=======================================
Coverage 80.72% 80.73%
=======================================
Files 49 49
Lines 3414 3415 +1
=======================================
+ Hits 2756 2757 +1
Misses 658 658
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
AiiDA keeps the original function in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the implementation.
@AndresOrtegaGuerrero Sorry, I didn't realize you mentioned this calcfunction call. This is really not necessary for the provenance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
fix #488 .
To avoid creating an aiida node every time we change the kpoints_distance, we use the function itself instead of the decorated calcfunction.