Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm structure and configuration steps when loading previous result #570

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

superstar54
Copy link
Member

fix #569

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (30ffe7a) 80.73% compared to head (7ab75b9) 80.79%.

❗ Current head 7ab75b9 differs from pull request most recent head 51636ba. Consider uploading reports for the commit 51636ba to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #570      +/-   ##
==========================================
+ Coverage   80.73%   80.79%   +0.05%     
==========================================
  Files          49       49              
  Lines        3415     3415              
==========================================
+ Hits         2757     2759       +2     
+ Misses        658      656       -2     
Flag Coverage Δ
python-3.10 ?
python-3.8 80.79% <100.00%> (+0.01%) ⬆️
python-3.9 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@unkcpz unkcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @superstar54
The changes make sense, I didn't give it a test myself but I trust you did it locally.

@unkcpz unkcpz added this to the v2023.10.0 milestone Dec 12, 2023
@unkcpz unkcpz merged commit 83bfea6 into main Dec 13, 2023
18 checks passed
@unkcpz unkcpz deleted the fix/569/load_and_set_step branch December 13, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Go to the submit step will reset previous steps
2 participants