Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs update on running docker container with docker desktop #586

Merged
merged 5 commits into from
Dec 22, 2023

Conversation

edan-bainglass
Copy link
Member

  • Update language
  • Add section describing how to spin up an aiidalab/qe container using Windows Docker Desktop

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (13d2eac) 80.86% compared to head (5686a39) 80.86%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #586   +/-   ##
=======================================
  Coverage   80.86%   80.86%           
=======================================
  Files          49       49           
  Lines        3429     3429           
=======================================
  Hits         2773     2773           
  Misses        656      656           
Flag Coverage Δ
python-3.10 80.86% <ø> (ø)
python-3.8 80.91% <ø> (ø)
python-3.9 80.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@unkcpz unkcpz self-requested a review December 21, 2023 12:02
Copy link
Member

@unkcpz unkcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @edan-bainglass, it is much more clear. I added a commit to break lines to keep one line for one sentence, which is the convention we used in both aiida-core doc and here. Hope you don't mind.

docs/source/installation/access_aiidalab/container.rst Outdated Show resolved Hide resolved
docs/source/installation/access_aiidalab/container.rst Outdated Show resolved Hide resolved
docs/source/installation/access_aiidalab/container.rst Outdated Show resolved Hide resolved
docs/source/installation/access_aiidalab/container.rst Outdated Show resolved Hide resolved
docs/source/installation/access_aiidalab/container.rst Outdated Show resolved Hide resolved
@edan-bainglass
Copy link
Member Author

Thanks @unkcpz. Even caught a typo 😅
All good with one sentence per line rule. Will keep that in mind for next time.

@unkcpz unkcpz changed the title Docs update Docs update on running docker container with docker desktop Dec 22, 2023
@unkcpz unkcpz merged commit ceb0b9a into aiidalab:main Dec 22, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants