-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs update on running docker container with docker desktop #586
Conversation
edan-bainglass
commented
Dec 21, 2023
- Update language
- Add section describing how to spin up an aiidalab/qe container using Windows Docker Desktop
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #586 +/- ##
=======================================
Coverage 80.86% 80.86%
=======================================
Files 49 49
Lines 3429 3429
=======================================
Hits 2773 2773
Misses 656 656
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @edan-bainglass, it is much more clear. I added a commit to break lines to keep one line for one sentence, which is the convention we used in both aiida-core
doc and here. Hope you don't mind.
Thanks @unkcpz. Even caught a typo 😅 |