Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links and instructions on running with Quantum Mobile images #588

Merged
merged 3 commits into from
Dec 22, 2023

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Dec 22, 2023

Link and instructions for:

  • M1/M2 apple silicon
  • x86_64

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ceb0b9a) 80.86% compared to head (d328537) 80.86%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #588   +/-   ##
=======================================
  Coverage   80.86%   80.86%           
=======================================
  Files          49       49           
  Lines        3429     3429           
=======================================
  Hits         2773     2773           
  Misses        656      656           
Flag Coverage Δ
python-3.10 80.86% <ø> (ø)
python-3.8 80.91% <ø> (ø)
python-3.9 80.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@unkcpz unkcpz force-pushed the doc/xx/add-qm-links branch 2 times, most recently from 94db42f to 060fefe Compare December 22, 2023 10:47
Copy link
Member

@edan-bainglass edan-bainglass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address my comments 🙏

@@ -4,9 +4,49 @@ Virtual Machine Image

.. note::

If you used another method to access AiiDAlab, you may proceed to :doc:`install the app </installation/install>`.
If you uses another method to access AiiDAlab, you may proceed to :doc:`install the app </installation/install>`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"used" is correct. Also, note that this note appears in several places in the site. We need to be consistent.


The AiiDAlab virtual image based on `Quantum Mobile <https://quantum-mobile.readthedocs.io/>`_ is available for the following architectures:
The AiiDAlab Quantum ESPRESSO virtual image based on `Quantum Mobile <https://quantum-mobile.readthedocs.io/>`_ is available for the following architectures:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When using "the following...:", ideally you should follow with a list. I recommend you add a bullet-point list with just the names, then add "See the following sections for instructions pertaining to your architecture." or something like it.

Also, maybe break down the sentence a bit - "The AiiDAlab Quantum ESPRESSO virtual image is based on the Quantum Mobile <https://quantum-mobile.readthedocs.io/>_ image and is available for the following architectures:"


Get AiiDAlab Quantum ESPRESSO virtual machine running on your computer in three simple steps:

#. Step1: Download virtual machine image (4.09 GB)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's already a numbered list. No need for "step1", etc.


Get AiiDAlab Quantum ESPRESSO virtual machine running on your computer in three simple steps:

#. Step1: Download virtual machine image (4.09 GB)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Download THE virtual machine...." - same in step 3

M1/M2 apple silicon
-------------------

If you have an M1/M2 apple silicon, you can use `UTM <https://mac.getutm.app/>`_ to run the AiiDAlab Quantum ESPRESSO virtual machine. The steps are as follows:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should apple and silicon be capitalized? I believe these are proper names of a chip, right? Also, add "chip" after silicon


If you have an M1/M2 apple silicon, you can use `UTM <https://mac.getutm.app/>`_ to run the AiiDAlab Quantum ESPRESSO virtual machine. The steps are as follows:

#. Step1: Download compressed virtual machine image (5.9 GB)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments as above regarding "step1" and "THE"


#. Step2: Decompress the zip file.
#. Step3: Install UTM (see https://mac.getutm.app/)
#. Step4 Import image into UTM by clicking on the Create a New Virtual Machine button and selecting the `quantum_mobile_23.10.0-qeapp.utm` file.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Italicize "Create a New Virtual Machine" for emphasis

+ MD5 hash: `5c80d9ab2458f2edac30e97dc2fe36e7`

#. Step2: Install Virtual Box 6.1.6 or later (see https://www.virtualbox.org)
#. Step3: Import virtual machine image into Virtualbox (11.2 GB) File => Import Appliance
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Italicize "Import appliance" for emphasis

@unkcpz
Copy link
Member Author

unkcpz commented Dec 22, 2023

Thanks for the review @edan-bainglass. All comments addressed. It is a very good English writing skills lesson for me. 😄

Copy link
Member

@edan-bainglass edan-bainglass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@unkcpz unkcpz merged commit 2ea253e into aiidalab:main Dec 22, 2023
7 checks passed
@unkcpz unkcpz deleted the doc/xx/add-qm-links branch December 22, 2023 14:17
@unkcpz
Copy link
Member Author

unkcpz commented Dec 22, 2023

Thanks @edan-bainglass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants