Use ruff as code formatter #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #593 +/- ##
=======================================
Coverage 80.86% 80.86%
=======================================
Files 49 49
Lines 3429 3429
=======================================
Hits 2773 2773
Misses 656 656
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@unkcpz thank you! , I noticed that the pre-commit.ci fail , could you have a look ? |
unkcpz
force-pushed
the
refac/xx/to-ruff
branch
from
5e38161
to
e582f92
Compare
unkcpz
commented
Jan 17, 2024
|
Okay, it was a bug of ruff |
AndresOrtegaGuerrero
approved these changes
Jan 19, 2024
unkcpz
added a commit
that referenced
this pull request
Jan 24, 2024
The problem is introduced by #593, where I move the load_profile to after the import of AWB.
unkcpz
added a commit
to unkcpz/aiidalab-qe
that referenced
this pull request
Jan 25, 2024
The problem is introduced by aiidalab#593, where I move the load_profile to after the import of AWB.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aiida-corefrom2.5.0start to move to using ruff as code formatter, it is much faster.