removing force_parity from create_kpoints_from_distance

[AndresOrtegaGuerrero]

This allows the app to follow the same logic of aiida-quantumespresso plugin, therefore displaying the final kpoint mesh as in the calculation

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c9d010a) 80.86% compared to head (45189c0) 80.86%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #598   +/-   ##
=======================================
  Coverage   80.86%   80.86%           
=======================================
  Files          49       49           
  Lines        3429     3429           
=======================================
  Hits         2773     2773           
  Misses        656      656           

Flag	Coverage Δ
python-3.10	80.86% <100.00%> (ø)
python-3.8	80.91% <100.00%> (ø)
python-3.9	80.91% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[unkcpz]

This allows the app to follow the same logic of aiida-quantumespresso plugin

Hi @AndresOrtegaGuerrero, what you mean of "same logic"? I look at the function in aiida-quantumespresso, but it has no default value defined for force_parity. https://github.com/aiidateam/aiida-quantumespresso/blob/c44faadc7c11f7118290cf1b7affe49313bd4467/src/aiida_quantumespresso/calculations/functions/create_kpoints_from_distance.py#L7

[AndresOrtegaGuerrero]

@unkcpz in the base workchain, https://github.com/aiidateam/aiida-quantumespresso/blob/main/src/aiida_quantumespresso/workflows/pw/base.py#L7

thats why the value we display is not necessarily the one is being used in the calculations since it should be force_parity false

[unkcpz]

Ah, I see, it is https://github.com/aiidateam/aiida-quantumespresso/blob/b517686df8cd33765ef12cbf430620ea8e94f137/src/aiida_quantumespresso/workflows/pw/base.py#L278 😉

[unkcpz]

Thanks!