Examples: Add Lithium Carbonate to List of Examples #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an oversight from aiidalab#614 where the lithium carbonate example was not added to `Examples` in `__init__.py` and was thus not selectable as a structure.
|
Hi @superstar54, many apologies for missing this in the PR. I think I had it set correctly when I was building the docs in the docker container, then switched development to the local machine and forgot to include this change. I tested it just now, also to confirm that the structure loads correctly, and everything seems fine. |
superstar54
approved these changes
Feb 14, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #622 +/- ##
=======================================
Coverage 77.48% 77.48%
=======================================
Files 55 55
Lines 4011 4011
=======================================
Hits 3108 3108
Misses 903 903
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
No worry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an oversight from #614 where the lithium carbonate example was not added to
Examplesin__init__.pyand thus couldn't be selected as a structure.