Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pw setting for molecule in XPS calculation #625

Merged
merged 2 commits into from
Feb 27, 2024
Merged

fix pw setting for molecule in XPS calculation #625

merged 2 commits into from
Feb 27, 2024

Conversation

superstar54
Copy link
Member

@superstar54 superstar54 commented Feb 27, 2024

For molecules, we use gamma_only and assume_isolated. This should be fixed in the aiida-quantumespresso XpsWorkchain, but we don't want to wait for the new PR and release. Thus, we fix it here directly.

I also adjust the supercell_min_parameter_map, so it uses the default 8.0 when the user selects the moderate protocol.

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 75.83%. Comparing base (f64607c) to head (bfecdef).

Files Patch % Lines
src/aiidalab_qe/plugins/xps/workchain.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #625      +/-   ##
==========================================
- Coverage   75.90%   75.83%   -0.08%     
==========================================
  Files          60       60              
  Lines        4291     4295       +4     
==========================================
  Hits         3257     3257              
- Misses       1034     1038       +4     
Flag Coverage Δ
python-3.10 75.83% <0.00%> (-0.08%) ⬇️
python-3.8 75.86% <0.00%> (-0.08%) ⬇️
python-3.9 75.86% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superstar54 superstar54 changed the title fix setting for molecule fix setting for molecule in XPS calculation Feb 27, 2024
@superstar54 superstar54 changed the title fix setting for molecule in XPS calculation fix pw setting for molecule in XPS calculation Feb 27, 2024
Copy link
Contributor

@PNOGillespie PNOGillespie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me and a quick test on my machine works with no issues. Good work @superstar54.

@superstar54 superstar54 merged commit 979f2e4 into aiidalab:main Feb 27, 2024
14 checks passed
@superstar54 superstar54 deleted the fix_xps_molecule branch March 3, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants