Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check code exist in the DEFAULT_PARAMETERS or not #660

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

superstar54
Copy link
Member

@superstar54 superstar54 commented Apr 3, 2024

fix #659 .
Skip setting the code if the code does not exist in the DEFAULT_PARAMETERS.

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 75.73%. Comparing base (91de25a) to head (05c82c8).

Files Patch % Lines
src/aiidalab_qe/app/submission/__init__.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #660      +/-   ##
==========================================
- Coverage   75.77%   75.73%   -0.04%     
==========================================
  Files          60       60              
  Lines        4317     4319       +2     
==========================================
  Hits         3271     3271              
- Misses       1046     1048       +2     
Flag Coverage Δ
python-3.10 75.73% <0.00%> (-0.04%) ⬇️
python-3.9 75.76% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superstar54 superstar54 merged commit 2381200 into aiidalab:main Apr 3, 2024
15 checks passed
@superstar54 superstar54 deleted the fix_659_set_default_code branch April 3, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set default code error
1 participant