check if the code is installed and usable #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superstar54
force-pushed
the
fix_664_check_code_is_usable
branch
from
e2589be
to
f3a86bb
Compare
| # note: if code is imported from another user, it is not usable and thus will not be | ||
| # treated as an option in the ComputationalResourcesWidget. | ||
| if _get_code_uuid(codes.get(name)) in code.code_select_dropdown.options: | ||
| code.value = _get_code_uuid(codes.get(name)) |
There was a problem hiding this comment.
Is there any issue if code.value is not defined ?
There was a problem hiding this comment.
Thanks for the review. The code is a ComputationalResourcesWidget, which always has a value attribute.
AndresOrtegaGuerrero
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #664
If code is imported from another user, it is not usable and thus will not be treated as an option in the
ComputationalResourcesWidget.